Open
Conversation
Member
|
Thanks for your pull request and sorry for the long silence. It makes indeed sense to have cyclic guards in place. With the current state, it is impossible to review the changes because the converter is fully duplicated. Instead, it would make sense to carry around a contextual state object that holds references to resolved objects from hashes and have that as starting point. |
d43adc9 to
a71f042
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! First of all I want to describe the problem that I have fixed.
Imagine a couple of
@RedisHashentities that references one to anoter like A <->B. In that case StackOverflow will be thrown because of infinite calls stack for resolving@Referencefields on any kind of reading.So I have made a clone of
MappingRedisConverterwith nameReferenceMappingRedisConverterbut with one difference.ReferenceMappingRedisConverterhas context of already resolved field branches,ReferenceRedisAdaptercontrol the context of converter on reading operations.I'm not really confident should I edit already existing classes or create new, this is why I have created new ones. I didn't know what version should I write in
@sincejavadoc annotation, so I just didn't write it.And of course I am ready to write documentation for my code and a sample configuration in spring boot, but I need a little bit explanation of how to do it.